cheesegrits
09-14-2007, 03:54 AM
My apologies to people waiting for their bugs to be fixed in SVN.
In order to fix an underlying problem, we've had to change the way "multiple value" params are stored. Whilst this doesn't involved a huge amount of changes in the code, it does require very careful testing. We are also having to come up with a "one shot" update routine that will make all the necessary changes to existing data.
The change involves anything which can have multiple instances in their admin parameters. Things like table joins and filters. Up till now, these multiple settings have been saved as comma separated values (CSV) in the db. This is apparently for "historical" reasons, as early versions of Fabrik used CSV config files. And it kind of stuck. But this breaks things like (for instance) eval'd "Value" params in a table filter, where you might have a line of PHP with, say ...
$foo = some_function("bar",123);
The comma in the above example causes runtime errors, because the code Fabrik tries to eval ends at the comma. So we're replacing comma separation with a bizarre string that is very unlikely to ever occur in the real world.
Anyway, because the other bugs I've fixed in the last few days involve the same files, I can't commit those changes till we get this param stuff 100% ready.
-- hugh
In order to fix an underlying problem, we've had to change the way "multiple value" params are stored. Whilst this doesn't involved a huge amount of changes in the code, it does require very careful testing. We are also having to come up with a "one shot" update routine that will make all the necessary changes to existing data.
The change involves anything which can have multiple instances in their admin parameters. Things like table joins and filters. Up till now, these multiple settings have been saved as comma separated values (CSV) in the db. This is apparently for "historical" reasons, as early versions of Fabrik used CSV config files. And it kind of stuck. But this breaks things like (for instance) eval'd "Value" params in a table filter, where you might have a line of PHP with, say ...
$foo = some_function("bar",123);
The comma in the above example causes runtime errors, because the code Fabrik tries to eval ends at the comma. So we're replacing comma separation with a bizarre string that is very unlikely to ever occur in the real world.
Anyway, because the other bugs I've fixed in the last few days involve the same files, I can't commit those changes till we get this param stuff 100% ready.
-- hugh