Error After Joomla Update to 3.9.16

[startpoint]

In edit list->details->layout
Fields: Front-end template, Admin template, PDF template are empty.
In Edit form->Layout
Fields: every dropdown for select template is empty
Warning: Invalid argument supplied for foreach() in /administrator/components/com_fabrik/models/fields/fabriktemplate.php on line 60

PHP - 7.2
Fabrik - Latest Github

 

[troester]

I've pointed it to @cheesegrits
Similar error
/administrator/components/com_fabrik/models/fields/fabrikfolderlist.php on line 54
e.g. if editing a viz

 

[startpoint]

Change Forum Topic to prevent update from others until problem resolve, if you can.

 

[troester]

Looks like a bug in Joomla.

They changed libraries\joomla\form\fields\folderlist.php to

$path = ltrim($this->directory, '/');
if (!is_dir($path))....

but after ltrim is_dir() is false and getOptions is returning NULL

 

[ereyes]

So the correction would be in the hands of Joomla? Right ?

 

[troester]

It's fixed in GitHub (Fabrik is skipping the Joomla issue).

 

[ereyes]

Excellent !
Thank you.

 

[flinx]

Hi, since for various reasons I cannot update via github for now I have restored the code of the joomla library bringing it back to the one previous to 3.9.16 do you think I will have problems from other parts of the site? do you think joomla will modify this bug?

 

[troester]

You should not restore (or update with) only parts of some code. It's likely that running Joomla3.6.19 with "old" Joomla library code will break somewhere.
I think (no warranty, but I have it done on some sites, too) you can run Joomla3.9.16 + original Fabrik3.9 + updating the 2 Fabrik files addressing the Joomla bug.
https://github.com/Fabrik/fabrik/commit/2bd6159d9777eade9b6d3e90d83ad64dd2546133
https://github.com/Fabrik/fabrik/commit/72268ca242a99cb1d562c0e419bf7677a8df22d2

 

[flinx]

Thanks, I did as recommended by troester and it seems to be working well, thanks again for avoiding me to act in a way that is surely wrong and dangerous for the site.

 

[hleithner]

Hi,

can someone please test Joomla Pull request 28393 found on github so I can merge it in Joomla! 3.9.17 to fix the issue for all extensions?

thx

Harald Leithner

 

[troester]

With https://github.com/joomla/joomla-cms/pull/28393 Fabrik is working again (Fabrik3.9 without the modifications made to skip this Joomla issue).

 

[hleithner]

Could you please write this as comment in github.

thx

 

[troester]

Done.

 

[hleithner]

Perfect thx

 

[mattsh]

You should not restore (or update with) only parts of some code. It's likely that running Joomla3.6.19 with "old" Joomla library code will break somewhere.
I think (no warranty, but I have it done on some sites, too) you can run Joomla3.9.16 + original Fabrik3.9 + updating the 2 Fabrik files addressing the Joomla bug.
https://github.com/Fabrik/fabrik/commit/2bd6159d9777eade9b6d3e90d83ad64dd2546133
https://github.com/Fabrik/fabrik/commit/72268ca242a99cb1d562c0e419bf7677a8df22d2

@troester Is "your" patch also needed for Joomla 3.9.18?
Running 30+ joomla sites....

Thanks
Matt

 

[troester]

No, they corrected the bug in J!3.9.17

But if you added the patch for J!3.9.16 it won't hurt with J!3.9.18.