element.php error !important

[dream]

after updating i got an error on every element on the page:

Notice: Undefined property: PlgFabrik_ElementInternalid::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementUser::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementField::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementDatabasejoin::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementDatabasejoin::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementTextarea::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementTextarea::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementDate::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342

Notice: Undefined property: PlgFabrik_ElementDate::$_element in /.../joomla/components/com_fabrik/models/element.php on line 342


page failed after updating with the latest master.
previous code page (element.php) had the following (starting line 110):

v.3.0.9 (manual download from github using 'tags')

/**
* Element object
*
* @var JTable
*/
var $_element = null;

latest master:

/**
* Element object
*
* @var JTable
*/
public $element = null;


in the latest master, i changed $element to $_element and the error went away. it seems to be what the rest of the code is looking for.

can someone please confirm this is a proper fix?

and should it remain 'public,' not var?

 

[jfquestiaux]

Are you sure you update form GitHub using the correct branch? "Master" is for Fabrik 3.0.9 - "Joomla3" is for Fabrik 3.1 (ignore the other branches).

 

[dream]

yes. definitely.
i'm going to check something tho.
...
yes, it's still doing it if the underscore is missing.

 

[troester]

I think this is really a typo, I've mentioned it to Rob/Hugh. But it's weekend...

 

[dream]

appears to be fixed.

 

[cheesegrits]

Yup, I fixed it when Troester mentioned it on Skype that weekend.

-- hugh