hide empty elements in details

[joit]

I saw this page
http://fabrikar.com/forums/index.ph...es/#showing-an-element-only-if-it-has-a-value

is this still up to date?
I want to hide ALL empty elements, this would become a huge code...

Thanks,
Hannes

 

[troester]

Empty elements have the CSS class

fabrikDataEmpty added and I think this set set to display:none (e.g. element is hidden) in the bootstrap details template per default.​

 

[joit]

I tried bootstrap which looked the same as "use default" and bootstrap tabs and it didn't hide empty elements, see pic

 

[troester]

The class is set.
But it seems it's not in bootstrap_tabs, so add a custom_css.php (copy and rename custom_css_example.php) with
#$form .fabrikDataEmpty {
display: none;
}

 

[joit]

Thanks!
But this brings up another question. How can I make "please select" values empty? or hide them otherwise?

 

[joit]

I should make this a little more clear. I have drop down elements with a "please select" value. these dropdowns won't disappear like the others.
I tried to leave the value of "please select" empty but then I can't save the element.
Any ideas?

 

[cheesegrits]

Hmmm. That's happening because technically, those elements aren't "empty". They have a potentially selectable value.

I'll have a look at the code, see if there's way of working round that.

Are these 'dropdown' elements, or join elements set to dropdown with the "please select" option enabled?

-- hugh

 

[joit]

It's just a problem with dropdowns. Database joins are hidden!

 

[cheesegrits]

Try setting your "Please select" value to -1.

-- hugh

 

[joit]

hmm I didn't work. If you log in the frontend of my site, you can check it here
/index.php/fahrten/details/3/361
On the second tab, there is a dropdown element "Gewicht in" which shouldn't be visible

 

[troester]

in
public function dataConsideredEmpty($data, $repeatCounter)
$data contains the label, not the value
Maybe something like replaceLabelWithValue() is missing?

 

[cheesegrits]

Yeah, looks likely. Checking the code now.

-- hugh

 

[cheesegrits]

OK, hopefully as of this commit it should be fixed:

https://github.com/Fabrik/fabrik/commit/bf4d8209ed5152cff007ee05d84cd186c4fdf216

... such that a value of 0 or -1 will be considered "empty".

-- hugh

 

[cheesegrits]

PS ... best thing would be to add YAFO so folk can specify what value(s) should be considered "empty", which just defaults to 0. But for now ... 0 and -1 it is.

-- hugh

 

[joit]

While this works for one form, it doesn't work for another form. Can this be a problem, if the element is a child of another dropdown element and I changed the parent element only instead of unlinking it?
Did you see trob's comment here?
https://github.com/Fabrik/fabrik/commit/bf4d8209ed5152cff007ee05d84cd186c4fdf216

 

[joit]

any idea?

 

[cheesegrits]

Yup, I saw that comment, and responded to it.

So you are saying it works on the parent element, but not on the linked copy of that that element on a copy of the form?

What's the link to that copy of the form?

-- hugh