Bug in email form plugin

[wezetel]

Just realized the placeholder definition for {fabrik_viewurl}, {fabrik_editurl}, {fabrik_viewlink} and {fabrik_editlink} in email.php has a small error and results in not working links.
On lines 164 and 166 the URLs are build, but instead of including 'formid' to identify the form, 'fabrik' is build in the URL.

 

[wezetel]

Btw.: these placeholders seem only to work in a php template...(or am I wrong?)

 

[cheesegrits]

You are right. These two commits should fix both problems:

https://github.com/Fabrik/fabrik/commit/c62e7b0199d6f31029c7b738da0be5f2ee148fc7
https://github.com/Fabrik/fabrik/commit/1bdf04cab1b15a44141da94423a651faa04b2c73

-- hugh

 

[wezetel]

Thanks Hugh,
so I'm the first one since 7 years who wants to use these placeholders....

 

[cheesegrits]

Looks that way. Although come to think of it, I think we actually have 'fabrik' as an alas for 'formid' in our router, so it probably works either way.

Sent from my HTC6545LVW using Tapatalk

 

[wezetel]

At least it didn't work for me..so the created email was probably bypassing the router?

 

[cheesegrits]

Ah, yes, I think I finally removed that alias in the router a little while ago. Late last year. So this would have been one of the first releases that the email links would have quit working.

-- hugh