Dropdown Eval Populate ignores Disable setting

[achartier]

I am populating a dropdown using php in the Eval Populate field. I am creating an array[] using multiple JHTML::_('select.option', ...) statements. I wish to have one or more items in the dropdown list disabled (they are parents with children, only non-parents can be selected). I do this using the disable option of the JHTML::_ select option.

For example:

$opt = JHTML::_('select.option', $item->value, $item->name );
if ( $item->children > 0 )  $opt->disable = true;
$list[] = $opt;

When I return the $list the dropdown is rendered but the disable option is being ignored.

 

[achartier]

Friendly bump...

 

[achartier]

Another friendly bump...

 

[achartier]

Alright, so here is a patch to fix the problem:

in components/com_fabrik/models/element.php insert the following function after the getSubOptionLabels function:

        /**
        * Get sub option enabled/disabled state
        *
        * @return  array
        */
 
        protected function getSubOptionEnDis()
        {
                $opts = array();
                $phpOpts = $this->getPhpOptions();
                if ($phpOpts)
                {
                        foreach ($phpOpts as $phpOpt)
                        {
                                $opts[] = $phpOpt->disable;
                        }
                }
                return $opts;
        }

And in plugins/fabrik_element/dropdown/dropdown.php

near line 58 find:

$labels = $this->getSubOptionLabels();

insert this after it:

$endis = $this->getSubOptionEnDis();

then change the foreach that follows as below:

foreach ($values as $tmpval)
{
            $tmpLabel = JArrayHelper::getValue($labels, $i);
            $disable = JArrayHelper::getValue($endis, $i);
            // For values like '1"'
            $tmpval = htmlspecialchars($tmpval, ENT_QUOTES);
            $opt = JHTML::_('select.option', $tmpval, $tmpLabel);
            $opt->disable = $disable;
            $opts[] = $opt;
            if (in_array($tmpval, $selected))
            {
                    $aRoValues[] = $this->getReadOnlyOutput($tmpval, $tmpLabel);
            }
            $i++;
}

 

[cheesegrits]

Thanks for the patch, getting it integrated now.

-- hugh

 

[achartier]

I confirm the patch has been applied to github and is working. Thanks Hugh.

 

[cheesegrits]

As per out discussion over in the 3.1 forums, this has now be ported forward to 3.2.

https://github.com/Fabrik/fabrik/commit/e291b32fe1ab5843a461c9e27291c82cd036e43a

-- hugh