Form button 'Save as copy' - Option 'Default on Copy' doesn't seem to work

[Borox]

Hi,

I used the button 'Save as copy' to quickly copy a specific form, it works but, I have a problem with the fileupload elements because the files themselves are not copied, we get an alias of the files ( the copy and the source point towards the same file).
So, I wanted to exclude the fileupload elements from the copy. In order to do that I put 'Default on Copy' to Yes but the fileload elements are still copied.

1 - Is there a way to avoid the copy of a specific element when we use the button 'Save as copy'
2 - Would it be possible for fileupload element to have a real copy, I mean, a copy of the file?

Thanks.

 

[Borox]

I checked with another type of element, with a 'field' the option 'Default on Copy' works ( the value is not copied), so it seems that it doesn't work only (at least) with filepload.

 

[cheesegrits]

Are you doing the copy from a list (using the Copy list plugin) or from the form (using the Save as Copy button)?

-- hugh

 

[cheesegrits]

Oh, you did say in your question. Sorry, still on my first cup of coffee.

-- hugh

 

[cheesegrits]

OK, try this:

https://github.com/Fabrik/fabrik/commit/6097de2e7310daae3ed7ba5226521addf2be8fdb

For your second question ...

2 - Would it be possible for fileupload element to have a real copy, I mean, a copy of the file?

It'd be possible, but I'd probably need to charge for an hour or two's work to do it, as it's not trivial to implement. Mostly because I have to account for s3 storage as well as local, plus dealing with multiple AJAX uploads.

-- hugh

 

[Borox]

I try the fix and I'll let you know

Thanks Hugh

 

[Borox]

Thanks Hugh, the fix works great!

For the moment excluding the files from the copy is enough for me, I'll see later if I need a real copy of them.

 

[Borox]

I've noticed something, which happened, I think, for all the elements:

It works, the fileupload's elements are not copied, but if you send an email using the 'form email plugin', when you copy a form, you still get the values. The variable 'data' (I use $this->data[...] to put the values in the email) seems not to be update and still contains a value that you find in the email.

Do I need to use another variable then 'data'?

Thanks

 

[cheesegrits]

Hmmm, yeah, I can see why that happens.

I think it's fixable. I'll take a look as soon as I get a chance this week.

-- hugh

 

[Borox]

@cheesegrits Hello Hugh,

Have you been able to fix it?

Thanks.

 

[cheesegrits]

Ooops, sorry. OK, looking at it now. Should have a fix by this evening.

-- hugh

 

[cheesegrits]

I'm testing a fix locally, I'll commit it later today.

-- hugh

 

[Borox]

OK Hugh, I'll test as soon as the fix is available

 

[cheesegrits]

https://github.com/Fabrik/fabrik/commit/15ba5422ba58720f0d42dae4b8657330377bb87b

As usual, I recommend doing a full github update rather than cherry picking individual files.

-- hugh

 

[Borox]

Hi Hugh,

I've done a full github update but no change, I still have in the first email sent the values ( not in the next emails)

 

[cheesegrits]

Can you paste the template code you are using.

-- hugh

 

[Borox]

Hi Hugh,

Here is the code used to get the pictures in the email sent after the form copy:

echo "<img src=".JURI::base().$this->data['contrats___contrat_photo_raw'].">";

Right after the copy the picture appears, even though the files is not in the new form ( the one copied).

In the email right after the copy:

In the email after a 'save' without touching anything:

Thanks.

 

[cheesegrits]

Ah, try just using the non _raw, which should already be an img tag (or empty).

-- hugh

 

[Borox]

Hi Hugh,

It doesn't work in my case.
I used the template debug.php to see the variables and there is nothing in the non _raw one ( neither if I'm supposed to have an image or if I'm not). That's probably why I used the _raw version in the first place.

I haven't made a copy, so I was supposed to have something in non raw variable:
View attachment 17182
In the raw:
View attachment 17183

Weird.

 

[cheesegrits]

OK, I'll keep working on it.

-- hugh