1. The forums have been upgraded to XenForo 1.4. Please post any issues or comments here.
  2. Our hosting provider will be performing some scheduled maintenance and upgrading during the early morning (US time) of Tue 28th July, starting at approx 2am EST, which will require some down time of the server.

very limited bug: on table view, the columns with sort ability don't active...

Discussion in 'Fabrik 2.0 Beta Testing' started by astroplan, May 1, 2009.

  1. astroplan

    astroplan New Member

    Level: Community
    very limited bug: on table view, the columns with sort ability don't active table resort render

    testing SVN at 1593

    CODE SEEK: /model/table.php CODE ROW: 1072-1078

    PROPOSAL JUST A FAST-FIX:
    moving the code row 1072 just before code row $strOrder .= " $field $dir"... like that:

    ...

    //build the order by statement from the session
    $strOrder = '';
    foreach ($orderByFields as $field) {
    // from here (row 1072)
    $context = 'com_fabrik.table'. $this->_id.'.order.'.str_replace('.', '___', $field);
    $dir = $session->get( $context );
    if ($dir != '' && $dir != '-' && trim( $dir ) != 'Array' ) {
    $strOrder == '' ? $strOrder = "\n ORDER BY " : $strOrder .= ',';
    // to here
    $field = FabrikWorker::getDbSafeName( $field );
    $strOrder .= " $field $dir";
    }
    }

    ...

    $orderByFields array mismatch anytime because $orderByFields array is composed without ` char (safemode).
     
  2. cheesegrits

    cheesegrits Support Gopher Staff Member

    Level: Community
    Fix has been applied in SVN. Resolves ticket number #391.

    Thanks for the debugging work, much appreciated.

    -- hugh
     

Share This Page