bug in form at render multicolumn group

[elkekas]

Joomla 4.26
Fabrikr 4b

When we have a multicolumn form there is a problem with the beginning and end of some fields. This is because there is an error in the code of the group.php file in the models directory. on line 549

$rowIx++;

The correct thing is to check that the field is not hidden, otherwise the hidden fields will also be checked to calculate the end of the line, giving unexpected results.

if (!$element->hidden)
{
$rowIx++;
}

In fabrik 3 code it is like this

Example form with 2 column with wrong code, the form with any hidden fields

With the correct code

 

[elkekas]

Another thought is to leave the code as it is, since if we play with the ordering of the fields we could control the end of the line and cause the line break at will. But it must be explained that hidden fields also count and leave holes

 

[troester]

Thanks for investigating and sorry for the incomplete (resp. not detailed enough) changelog https://github.com/joomlahenk/fabrik/wiki/Changelog

This is already fixed, also some glitches with group end <div.
See https://github.com/joomlahenk/fabrik/issues/607 and https://github.com/joomlahenk/fabrik/issues/603

We are in the process of moving and handling issues, Fabrik4 WIKI etc to/in this forum. So at the moment the informations are a bit divided.

 

[elkekas]

Don't worry.
Thank you very much for the wonderful work.

I will continue testing and verifying functions.