Strange issue with User element in repeated group in details view

[troester]

Setup (tested with 2 sites; one with latest Git, one with Git 2014-07-24):

List1 with user element (update on edit=no)
List2 joining to list1
on list1.id = list2.fk, repeatable.
The repeated group with the user element is displayed correctly in list view and in form view.
But in details view all user elements but the last one are empty, the last one is displaying the user element which should be in the first group entry.

It's ok if the user element is changed to a dbjoin to #_users.

Any idea?

 

[rob]

yeah I can replicate this one. That part of the code is really messy, seems to be trying to test a load of stuff that may or may not be needed now.
I've got something working locally, but I want to start to write unit tests for anything like this that I fix as its the kind of change that may result in a bug elsewhere, then fixing that bug unfixes the original fix etc. At least with a unit test we can see that the original fix is still good.
in the mean time, if its urgent, let me know and I can set up a branch set up with the changes

 

[troester]

It's not urgent as setting the element to dbjoin with default = {$my->id} is sufficiant (if update on edit=no).

 

[rob]

Ive started on the unit tests but theres just too much set up work involved at the moment. I will try to pick it up when Hugh's back