[FIX] Can't Create Form Without Selecting Group

[Kaylakaze]

I don't know if anyone else has this problem, but just figured I'd post my solution.

You'd think, if you select "Create a group with the same name as this form" when creating a form, that you wouldn't be required to then select a group, especially since the word "Or" is in there, but due to a bad JavaScript check, the system doesn't check the value of that button and just assumes that if your group list is empty, it's invalid. Here's how to fix the JavaScript.

In file \administrator\components\com_fabrik\views\form\tmpl\bootstrap.php:
After

var currentGroups = document.id('jform_current_groups');

add

var createNew = jQuery('input[name="jform\\[_createGroup\\]"]:checked').val();

and a few lines down, replace

if (typeOf(currentGroups) !== 'null' && currentGroups.options.length === 0) {

with

if (typeOf(currentGroups) !== 'null' && currentGroups.options.length === 0 && createNew != 1) {

This seems to do the trick.

 

[cheesegrits]

Makes sense. We'll need a non jQuery way of getting the createNew status (as this code has to run on J! 2.5 as well, which may or may not have jQuery loaded), but the logic is sound.

I'll get that fixed ASAP.

-- hugh

 

[cheesegrits]

OK, should be fixed as of this commit:

https://github.com/Fabrik/fabrik/commit/a471754ec3ae1a8d2b2d8b346dd8e13debba335e

Thanks,

-- hugh