getting warning after latest update (i think...) when displaying list

[skyrun]

doesn't happen on sites that havent' been updated recently.
View attachment 17211
YOU CAN PASTE IMAGES in here now.... cool beans!

a (i think great) clue is that if i do a search that has one guest per reservation (which is a join, there can be multiple guests and multiple properties too for that matter), the warning is not displayed... on the query above, the first reservation (4351) has 2 guests and gets the warning.

that's a custom template that displays the list, so perhaps could be something that needs updating on my template...

 

[cheesegrits]

I fixed that this morning in github.

https://github.com/Fabrik/fabrik/commit/83b93795ccc7441635f0737bbcbe2eab629c5605

-- hugh

 

[skyrun]

thanks.

fyi i just updated from https://codeload.github.com/Fabrik/fabrik/legacy.tar.gz/master before i sent this to you (about 2 horus ago). and for good measure i just updated again, and i'm still getting the warning. so there is a possibility that hasn't been committed in the repository i am using above. i don't cache, tried ctrl+f5 and incognito mode.

 

[cheesegrits]

Ah, just noticed that it's a slightly different error msg.

That's a result of merging this PR:

https://github.com/Fabrik/fabrik/pull/2039

I'll see if I can figure out what your error msg is telling us. The msg looks like it's seeing an &, which it expects to be an HTML entity, but there's no matching ;, so probably an unencoded &.

I seem to recall elsewhere in the code where we use DOMDocument we have to encode entities, I'll try and dig that up.

-- hugh

 

[cheesegrits]

OK, hopefully fixed as of this commit:

https://github.com/Fabrik/fabrik/commit/16cb217fd69fc992f7d68bfe8a7c9a33f247112e

-- hugh