Another bug in Yes/No plugin

[janon]

I was poking around the Yes/No plugin after seeing the recent posts and noticed FireFox was the only browser where the Yes/No image path was correct while with the others the image path was rendered with an absolute local file path.

Opera (not shown in screenshot) had the same problem but also has a separate issue with some fabrik javascript failing (Uncaught exception: TypeError: 'j.inject(document.body).hide' is not a function), I'll save that one for later.

 

[felixkat]

I've noticed something similiar with with ratings plugin, although I haven't diagnosed why yet. Images work okay in list but not form, I didn't think of trying different browsers on something like that, but I will.

 

[janon]

Found the issue, made a pull request

https://github.com/Jebtrix/fabrik/commit/0a56dfea8986cc221a9615f808f31d2f5cd34617

 

[janon]

Ratings showed up fine for me in form. Though I see display issue introduced a couple commits back.

 

[janon]

Nevermind your right, browser caching prob, ratings has the same issue.

 

[janon]

Well after more poking around this malformed pathing was in a couple of places. I updated my pull request on Git. The sliders now appears in colour picker, ratings in forms, and a couple others.

 

[rob]

the pull request should now be merged!
Thanks a lot for taking the time to fix this