Calendar visualization : ReadOnly mode allow double clic

[titoftit]

Hi,

When Read Only mode is set to on, I can double clic on calendar, and open popup details with Save button.

The problem seems to come from this line in the file calendar.js (and calendar-min.js), function openAddEvent :

if (this.options.canAdd === false)

if I replace with :

if (this.options.canAdd == false)

it's works great.

Because, when Read only mode is false, canAdd is equal to true, but when Read only mode is true, canAdd is equal to "0", and === operator do not type conversion.

 

[rob]

thanks for the heads up - I fixed it in the other sense - making sure that canAdd is a a boolean. (changes are in this commit - https://github.com/Fabrik/fabrik/commit/28ac440b21a9bffedde521704960607cfed4971b)

 

[titoftit]

And thanks for the quick fix