FIxed: Related data list in popup window, is not setting data-rowid

[PaulV888]

Hi,

When I show related data on a list as popup, then the edit/detail buttons on the popup list do not have data-rowid's and thus not loading the next window properly.

See image
1) List related data, as popup
2) Edit/Detail links do not have data-rowid setup, related data list Ajaxify Links -> Yes
3) Not loading data

Tracing this back, it seems like:
In fabrik-edit-button.php $display->rowId is empty
In list.php function getSlug return '' on line 5927.
I gave up here, I could not find why this would work in non-popup but not in a popup. I did put a band-aid in by changing line 5927 to return $row->__pk_val;


That seems to work, excited to see what this will break (or not)

Paul

Correction: Line: 5942

 

[cheesegrits]

Thanks for the sleuthing.

Should be fixed as of this commit:

https://github.com/Fabrik/fabrik/commit/87390d10a1557396afe1d60577ee6b6d6b84ff14

Needed to add 'partial' to the list of formats we create a slug for. Popups have to use a special document type we provide called 'partial', which has to handle not including any JS files which were included on the main page, otherwise you get nasty things happening when stuff like jQuery gets reloaded, replaces the original jQuery object on the main page, and blows away anything which was built in it.

-- hugh

 

[PaulV888]

Fixed, thanks