Urgent - Latest GIThub update has blown away all records

[p38]

Hi Guys,

Just updated my working site, and now it seems all pre filters are not working on all of my 20 or so lists.....

Something has broken.........

Clearing the filter still no joy, so I suspect a pre filter problem. This only happens on lists that I have allowed drop down filters and added an eval of default values eg:

return FabrikHelperElement::filterValue(289);

This is urgent, as my site has no more data for clients to view......

Paul

 

[rob]

hi - can you give me a url to a list that is displaying this issue?

 

[rob]

im looking at tournament scores (index.php/my-tournament-info/tournament-scores)
and i see the data

 

[p38]

Hi Rob,

try Teeoff Time, same list your worked on yesterday

http://golfscore.co.za/index.php/setup/teeoff-times


Paul

PS: I know data is there in underlying database , but lists are not showing, and this occurred the minute I got the latest update.

 

[p38]

I see it only works if 2 dropdown filters are selected, whereas in the past, it would work when one dropdown was selected.

I also see when using 3 or more filter dropdowns, the dropdown lists are not populated

Paul

 

[rob]

thanks - im looking at the site now

 

[rob]

i Think i have fixed this now on your site, the fix i did for you the other day stopped prefilters from working, and the fix to that stopped blank filters from overwriting the session filters. Bit of a round about of bug fixing

I'll wait a bit before committing those files though as I think I need to ensure that the latest set of changes haven't broken something else.
-Rob

 

[p38]

Thanks very much, we are getting there, at least the data is now showing

It seems as tho the pre-filter is not working, my prefilters are userid = {$my->id} as the data for ALL clients is showing, instead of just the logged in clients data.

Also, lists with filters 3 or more are not being populated in the dropdown.

thanks,

Paul

 

[p38]

Any joy yet Rob?

Unfortunately all clients data is now available to ALL users, so my site is compromised....... I need to get this back asap please?

Paul.

 

[p38]

Urgent bump.

Rob, please can you attend to this, we have a competition tomorrow and I cannot roll back to older GIT update as there were too many bug fixes that would compromise my working site.

At the moment, all my clients can see everyones data as the prefilters are not working.

 

[rob]

sorry I left work at 6pm so missed your messages. Looking now.

 

[rob]

ok should be fixed - sorry about all these recent issues.

 

[p38]

no worries, I understand software......

many thanks, all looks good,

Could you please look at the last issue in this thread please.

inline edit does not default field value | Fabrik

Paul

 

[p38]

bump

Not sure if you still busy, but was just testing now using inline edits, and I get this error when saving........

Notice: Undefined variable: package in /usr/www/users/indooatxdt/golfscore.co.za/components/com_fabrik/models/list.php on line 4631 Notice: Undefined variable: package in /usr/www/users/indooatxdt/golfscore.co.za/components/com_fabrik/models/list.php on line 4631 Notice: Undefined variable: package in /usr/www/users/indooatxdt/golfscore.co.za/components/com_fabrik/models/list.php on line 4631 Notice: Use of undefined constant houghton - assumed 'houghton' in /usr/www/users/indooatxdt/golfscore.co.za/plugins/fabrik_form/php/php.php(349) : eval()'d code on line 1 Notice: Undefined variable: value in /usr/www/users/indooatxdt/golfscore.co.za/plugins/fabrik_form/php/php.php(349) : eval()'d code on line 17 0

 

[cheesegrits]

rob just made some changes in the package code, which I suspect is at the root of the "undefined variable: package".

-- hugh

 

[cheesegrits]

That line number (4631) doesn't jive with the current github, and from the look of the current code, should be fixed.

Also, the 'use of undefined constant houghton' in eval()'ed PHP probably means you are using the word houghton without quotes, like 'houghton', around it in one of your custom PHP scripts.

Likewise, you are using $value somewhere, without defining it.

-- hugh

 

[p38]

Hi Hugh,

I have not touched my site in 2 months, and all this happened when I updated from GIT.

Rob fixed some bugs, and there are some minor issues remaining.

Also, a few of the bug fixes over the past while seems to have been omitted from GIT, so some of the corrections Rob made were probably not pulled to GIT.

Lastly 'houghton' is the content of an element in a list, which I guess is taken from placeholders or filters. Nowhere on the site do I hardcode any constants, everything is pulled using fabrik.

Paul.

 

[cheesegrits]

In which case, you are probably using a placeholder without surrounding it in quotes.

Remember that we pre-process your PHP fragments, BEFORE they are eval'ed. So a line of code like ...

$foo = {yourtable__yourelement};

... will get modified to ...

$foo = whatever_your_element_contained;

... before we hand it to PHP to eval it. So if you don't put quotes around your placeholders, and the element value is not a number, then that'll generate a syntax error.

So you pretty much always need to put quotes around palceholders. Even if you think the value should always be (say) an integer, still do this:

#foo_number = (int)'{yourtable___yournumber'};

... i.e. cast the result to an int, to catch cases of an empty string.

-- hugh

 

[p38]

Ok, I do not use many eval codes, and recall something about quotes, and have used this,\\however, i will go and check everything to make sure.

thanks,

regards

Paul

 

[cheesegrits]

As for git ... when did you do the last gihub update?

The changes I'm referring to were made today.

You can always check this yourself.

That error message gives you the the filename and line number. If you go to our main github page (in my sig), and look at the Commit list, you'll see a commit which involves changes to that file, so you immedeiately know your version is out of date, if that commit was after you last updated.

You can then navigate through the code tree to that file:

Fabrik/fabrik at master ? GitHub

... and switch the view to "Show Blame". "Blame" mode shows which commit last affected any given line of code.

If you skip down to the line number referenced in the error message, you'll notice that the $package variable the error talks about is not reference on that line. But a few lines up, it is, and it was changed in a commit done today.

As for changes made by Rob maybe not being in github, I can't help there. From reading this and other threads, it looks like that has now been resolved, and all changes made to your site are now in github. We very rarely make changes to someone's site which we don't then put in github, and if it happens, it's usually just oversite.

So, in this case, we need to ask rob is there is anything he needs to commit to github, before you update again.

-- hugh