Youtube element - allowfullscreen ?

[rbuelund]

If I set the "Allow fullscreen button" to yes on the youtube element, I am still not allowed to press the Fullscreen button - it is there but cannot be pressed ??
If I watch the source code on the site I also cannot see the tag "allowfullscreen" ?? The inserted code from the field looks like this:

<iframe
type="text/html"
width="100%"
height="300px"
src="https://www.youtube.com/embed/EIFQ9yczcJ0?autoplay=0&fs=1"
frameborder="0"
></iframe>

 

[rbuelund]

Just found the solution myself. In the file /plugins/fabrik_element/youtube/layouts/fabrik-element-youtube-detail.php there needs to be added som code:
From:
<iframe
type="text/html"
width="<?php echo $d->width;?>"
height="<?php echo $d->height; ?>"
src="<?php echo $d->url; ?><?php echo $d->vid; ?>?autoplay=<?php echo $d->autoplay; ?>&fs=<?php echo $d->fs; ?>"
frameborder="0"
></iframe>

to this:

<iframe
type="text/html"
width="<?php echo $d->width;?>"
height="<?php echo $d->height; ?>"
src="<?php echo $d->url; ?><?php echo $d->vid; ?>?autoplay=<?php echo $d->autoplay; ?>&fs=<?php echo $d->fs; ?>"
frameborder="0"
<?php if ($d->fs) {echo 'allowfullscreen';} ?>
></iframe>

Then the fullscreen button also works for youyube videos. Could you please add this code to github ?

 

[lousyfool]

Could you please add this code to github ?

You could do a pull request there yourself.

Though I also think that most users must like to have the fullscreen option by default, I'm not so sure if it makes sense to put it in after all these years...
Especially since there's no need for changing the core code: anyone can make it a layout override and add this and other attributes, or else: http://fabrikar.com/forums/index.ph...ing-an-element-jlayout-for-a-specific-element

 

[rbuelund]

As you write "most users must like to have the fullscreen option by default"
. It does not work as the code is right now.

 

[lousyfool]

You could do a pull request there yourself.

 

[rbuelund]

I do not know how

 

[lousyfool]

https://docs.github.com/en/free-pro...-issues-and-pull-requests/about-pull-requests

 

[rbuelund]

Did so now.

 

[lousyfool]

Did so now.

Are you sure? I don't see it there... https://github.com/Fabrik/fabrik/pulls

 

[rbuelund]

Now it is there..