Date element rewinds 6 hours on validation fail - github 12/1/16

[nbradshaw]

I have a date element with time enabled. I have eval enabled to show current day with time of 00:01.

When I save the form without filling in the required fields - the time will rewind 6 hours.

I have the time set to Local Time.

Please see attachments.

 

[nbradshaw]

As an FYI - this also is affecting my other forms that do not have the eval feature enabled.

 

[cheesegrits]

Does it make any difference whether you store as UTC or local?

-- hugh

 

[cheesegrits]

And I'm assuming your TZ is GMT-6?

-- hugh

 

[cheesegrits]

OK, try this ... in ./plugins/fabrik_element/date/date.js, around line 426, in shouldApplyTZ(), change ...

            if ($newRecord)
            {
                //if (($alwaysToday || $defaultToday) || $formModel->hasErrors())
                if (($alwaysToday || $defaultToday))
                {
                    // User supplied defaults should be in GMT, they are only applied if no other default found.
                    return true;
                }
            }

... so comment out the existing test, and try without the $formModel->hasError().

-- hugh

 

[troester]

Could this also be the reason here (editing a cron job will reset the "last run" time)?
https://github.com/Fabrik/fabrik/issues/1590

 

[cheesegrits]

https://github.com/Fabrik/fabrik/commit/5b2c9a41056cf9e871cb7ba557621bc215508262

-- hugh

 

[troester]

Yup, this commit fixes the cron last run issue.

Although it's still showing UTC in list view (e.g. 18:01) and local time in edit view (20:01), but this time is fix, not modified on save anymore.

 

[nbradshaw]

Ok - I updated github today - and I still am experiencing this. I also changed the element to UTC - and still rewinds 6-hours. I am Central Time - so I am -6 from GMT.

 

[nbradshaw]

I also cleared my cache just to be sure - problem is still there.

 

[cheesegrits]

Ok - I updated github today - and I still am experiencing this. I also changed the element to UTC - and still rewinds 6-hours. I am Central Time - so I am -6 from GMT.

That's because I haven't made any changes to the date element, as you never got back to me:

OK, try this ...

... by which I meant try the fix I suggested, let me know.


That commit I made was just for the cron issue @troester mentioned.

-- hugh

 

[nbradshaw]

ah - ok...I thought the commit would cover it. I am attaching my date.js file from the github from today...I am having trouble finding the text that you are mentioning. I changed the filename from .js to .txt for the upload.

 

[troester]

Hugh posted the wrong extension, it's not in date.js file but in date.php

 

[cheesegrits]

Ooops. Yes, date.php.

-- hugh

 

[nbradshaw]

Ok - I made changes to date.php...and unfortunately - it is still rewinding 6 hours. Any other thoughts?

if ($newRecord)
425                         {
426                                 //if (($alwaysToday || $defaultToday) || $formModel->hasErrors())
427                                 if (($alwaysToday || $defaultToday))
428                 {
429                                         // User supplied defaults should be in GMT, they are only applied if no other default found.
430                                         return true;
431                                 }
432                         }

 

[cheesegrits]

Not off the top of my head. And I'm on an Interstate somewhere near Savannah, Georgia atm. I'm on the road, visiting family. I'll take a look once I'm at a computer again, which will probably be tomorrow.

Sent from my HTC 10 using Tapatalk

 

[nbradshaw]

Hi Hugh - hope you enjoyed a little time off. Are you able to duplicate this in your environment? What type of logs/troubleshooting can I provide you to try and nail this down?

 

[cheesegrits]

With that fix, I just can't replicate it, either on new , or edit:

http://screencast.com/t/Nn548tQ8

(I forgot to induce a validation failure on the 'edit' test first time)

I'll need to login to your site and look. Is it the ericdashboard one?

-- hugh

 

[nbradshaw]

ok - so just to confirm - you were able to duplicate it before the fix in date.php?

I am on a private server...I am going to look into getting you vpn credentials.

 

[cheesegrits]

Yes. If I use the un-fixed code, I get what you observe, with the TZ getting applied when it shouldn't:

http://screencast.com/t/wNrpH82Pe

-- hugh