Error handling if calling a unknown record

[troester]

Setup:
A link in an email calling a form where the record is only accessible for the logged in user (list prefilter).
The record is not found (correct) if the user is not logged in.

But Fabrik is throwing a runtime exception "requested page not found" (around line 3223 form.php). Is there a special reason not to do

JError::raiseWarning(500, FText::_('COM_FABRIK_COULD_NOT_FIND_RECORD_IN_DATABASE'));
return false;

to have a "nice" error message inside the normal Joomla page?

 

[cheesegrits]

Hmmm. I don't think there's any particular reason, I think that just got changed as we're working on gradually moving the error handling in to a catch/throw approach, but I guess we're not catching that one anywhere. In 3.0 we just did a raiseNotice().

I'll go ahead and change it.

https://github.com/Fabrik/fabrik/commit/e015d69acec97b2cd6bbc8c701c1974976e604b0

-- hugh

 

[troester]

Thanks.
I didn't dare to do it myself in the official GitHub.

 

[cheesegrits]

I was a little hesitant, in case there was some very specific reason it got changed in 3.1.

But I guess we'll find out, if my change provokes some nasty problems elsewhere.

-- hugh